Gtf creation #40
Merged
Gtf creation #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 3, 2019 16:41
SebastianBeyvers
added
bug
renewiegandt
requested changes
Jan 6, 2019
| def __init__(self, out_file): | ||
|
|
||
| # Constructor | ||
| # input_parameter: out_file = Path to Outputfile |
| # is_data_dir = is wd data_dir or not | ||
|
|
||
| # return_value: Link to Chainfile for conversion. | ||
| # Custom chainfiles and chainfiles for more organism can be specified in this section |
| # wd = working directory | ||
| # is_data_dir = is wd data_dir or not | ||
|
|
||
| # return_value: Link to Chainfile for conversion. |
|
|
||
| def test_read_file(self): | ||
|
|
||
| # Method to testread the file |
There was a problem hiding this comment.
'testread' sounds and looks strange. Maybe "Method to test file format" would be a better comment.
| # Find activity categories in bed file | ||
| # input_parameter: line = current line from bedfile |
| # Method to get ucsc-celltype categories from JSON config | ||
| # input_parameter: organism = organism parameter | ||
| # wd = working directory, to find config fil |
| # input_parameter: organism = input organism | ||
| # release = used Ensembl release | ||
| # wd = working directory (default is ".") | ||
| # data_dir = data directory (if specified this is used) |
There was a problem hiding this comment.
Maybe you should write what is used if it is not specified
renewiegandt
requested changes
Jan 6, 2019
bin/3.1_create_gtf/Modules/Ensembl/FTPHandling/VersionChecker.py
Outdated
Show resolved
Hide resolved
| # input_parameter: organism = input organism | ||
| # release = used Ensembl release | ||
| # wd = working directory (default is ".") | ||
| # data_dir = data directory (if specified this is used) |
added 8 commits
January 6, 2019 16:42
renewiegandt
approved these changes
Jan 8, 2019
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved GTF-Creation Fixed a lot of bugs and formatting issues. More structured comments.